Differential D48409

stand/usb: Update for devclass being removed from DRIVER_MODULE
ClosedPublic
Actions

Authored by jhb on Fri, Jan 10, 3:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 15, 5:22 AM

	Unknown Object (File)
	Tue, Jan 14, 5:53 AM

	Unknown Object (File)
	Mon, Jan 13, 8:06 PM

	Unknown Object (File)
	Mon, Jan 13, 7:33 PM

	Unknown Object (File)
	Sun, Jan 12, 9:22 PM

	Unknown Object (File)
	Sun, Jan 12, 8:41 PM

	Unknown Object (File)
	Sun, Jan 12, 4:20 AM

	Unknown Object (File)
	Sat, Jan 11, 8:59 AM

View All 11 Files

Subscribers

Details

Reviewers

imp
markj
emaste
manu

Commits

rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE

Summary

The kshim code abused the devclass argument to DRIVER_MODULE in some
odd ways. Instead, refactor the devclass handling to more closely
mirror what new-bus does in the kernel by having a linked list of
devclasses looked up by name and associate devices with a devclass.

Devices are now only associated with a module while probing and
attaching.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61633
Build 58517: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Jan 10, 3:22 AM

Herald added a reviewer: manu. · View Herald TranscriptFri, Jan 10, 3:22 AM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Fri, Jan 10, 3:22 AM

Harbormaster completed remote builds in B61633: Diff 149030.Fri, Jan 10, 3:22 AM

jhb added a child revision: D48410: stand/kshim: Implement bus_detach_children.Fri, Jan 10, 3:22 AM

Love the concept. Spot checked the impl. Structure is good, but didn't dive deeply in.

This revision is now accepted and ready to land.Fri, Jan 10, 4:40 AM

jhb added a parent revision: D48404: kshim: Replace bus_generic_attach with bus_attach_children.Fri, Jan 10, 12:03 PM

markj accepted this revision.Fri, Jan 10, 1:54 PM

Closed by commit rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE (authored by jhb). · Explain WhySat, Jan 11, 4:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE.

Revision Contents
Changeset List

Path

Size

stand/

kshim/

11 lines

140 lines

usb/

storage/

4 lines

Diff 149030

stand/kshim/bsd_kernel.h

Loading...

stand/kshim/bsd_kernel.c

Loading...

stand/usb/storage/umass_common.c

Loading...