reduce is uninitialized, if the code path for logging is reached via goto old_method;.
CID: 1557359
Details
Details
- Reviewers
rrs rscheff cc peter.lei_ieee.org lstewart glebius - Group Reviewers
transport - Commits
- rG4c89d59e0cda: TCP RACK: don't log an uninitialized value
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Why not move the old_method: label above the stack variables' declaration? I think it may be cleaner to read.
Like this:
old_method: uint64_t cwnd, tr_perms = 0; int32_t reduce = 0;
Comment Actions
I prefer declarations before code in a block and label inside the code block. Maybe this is just a personal preference. But I also had to look up the specification if Coverity is correct in stating that the variable might be unused...