TCP BBR: remove dead code
AcceptedPublic
Actions

Authored by tuexen on Mon, Jan 6, 8:37 PM.

Details

Reviewers

rrs
rscheff
cc
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Summary

No functional change intended.
CID: 1523802

This is a last fix for BBR in this series.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mon, Jan 6, 8:37 PM

Herald added a reviewer: transport. · View Herald TranscriptMon, Jan 6, 8:37 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Mon, Jan 6, 8:37 PM

peter.lei_ieee.org added inline comments.Wed, Jan 8, 4:06 PM

sys/netinet/tcp_stacks/bbr.c
6827	I think this `if ((int) t <= 0)` condition could also be removed for similar reasons?

I agree with Peter :)

This revision is now accepted and ready to land.Wed, Jan 8, 6:09 PM

cc accepted this revision.Wed, Jan 8, 8:16 PM

Address comment raised by Peter. Coverity also reported it, which I overlooked.

This revision now requires review to proceed.Wed, Jan 8, 9:41 PM

peter.lei_ieee.org accepted this revision.Thu, Jan 9, 12:01 AM

This revision is now accepted and ready to land.Thu, Jan 9, 12:01 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

2 lines

Diff 148829

View Options

sys/netinet/tcp_stacks/bbr.c

TCP BBR: remove dead codeAcceptedPublicActions