Page MenuHomeFreeBSD
Differential D48309

netlink: fix size comparison
AcceptedPublic
Actions

Authored by glebius on Fri, Jan 3, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 9:57 AM
Unknown Object (File)
Mon, Jan 6, 8:58 AM
Unknown Object (File)
Mon, Jan 6, 5:32 AM
Unknown Object (File)
Sat, Jan 4, 5:36 PM
Unknown Object (File)
Fri, Jan 3, 10:41 PM
Subscribers
imp
markj

Details

Reviewers
melifaro
markj
Group Reviewers
network
Summary

We want to check the size of the header, not a pointer to it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61488
Build 58372: arc lint + arc unit

Event Timeline

glebius created this revision.Fri, Jan 3, 6:29 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 3, 6:29 PM
glebius requested review of this revision.Fri, Jan 3, 6:29 PM
Harbormaster completed remote builds in B61488: Diff 148744.Fri, Jan 3, 6:29 PM
glebius added a parent revision: D48308: netlink: add snl(3) primitive to obtain group ID.Fri, Jan 3, 6:29 PM
glebius added a child revision: D48310: netlink: snl_create_genl_msg_request() may fail due to ENOMEM.
markj accepted this revision as: markj.Fri, Jan 3, 6:32 PM
markj added a subscriber: markj.
markj added inline comments.
sys/netlink/netlink_generic.c
70

It's nicer IMO to use sizeof(*hdr), although netlink is inconsistent about this.

This revision is now accepted and ready to land.Fri, Jan 3, 6:32 PM
glebius added inline comments.Fri, Jan 3, 6:43 PM
sys/netlink/netlink_generic.c
70

I personally prefer sizeof(type) when coding protocols that exchange data, cause a protocol specification talks about types not about our local variable names. That makes it easier to check that code follow protocol spec. For other cases I prefer sizeof(*var), cause var type may change, and often does.

Revision Contents
Changeset List

PathSize
sys/
netlink/
3 lines

Diff 148744

View Options

sys/netlink/netlink_generic.c

Loading...