iwm: update firmware names for 7000/31xx series NICs
AbandonedPublic
Actions

Authored by adrian on Fri, Dec 27, 2:20 AM.

Details

Reviewers

manu
bz

Group Reviewers

wireless

Summary

A previous commit deleted the firmware kernel modules and installed
the firmware in /boot/firmware, but it didn't follow it up with
changes to the firmware names.

This left the iwm driver unable to function.

This commit fixes it for the 7xxx/31xx series NICs, although I've
only tested it on the Intel 7260 for now.

Also, this doesn't fix the 8xxx/9xxx series NIC firmware names as
those haven't been migrated to /boot/firmware/, so there's currently
no firmware for them.

Locally tested:

Intel 7260, STA mode

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61343
Build 58227: arc lint + arc unit

Event Timeline

adrian created this revision.Fri, Dec 27, 2:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Dec 27, 2:20 AM

adrian requested review of this revision.Fri, Dec 27, 2:20 AM

Harbormaster completed remote builds in B61343: Diff 148414.Fri, Dec 27, 2:20 AM

adrian added a parent revision: D48172: net80211: add macros for testing if a channel is defined / channel is "any channel".Fri, Dec 27, 2:22 AM

adrian added reviewers: wireless, manu.

adrian added a project: wireless.

adrian added a child revision: D48209: iwm: update rate tables from OpenBSD.Fri, Dec 27, 3:34 AM

Can you please start a new stack for a different driver?

If you do not need the old firmware anymore please remove it entirely and update the documentation.

There is HOWEVER a theoretical problem there: if iwlwifi ever bumps the firmware version, say for a security update, there is not guarantee that iwm can parse them properly.

Not sure I understand.
The firmwares are installed in /boot/firmware and loads correctly here, why do you want to use the iwlwifi firmwares ?

This revision now requires changes to proceed.Fri, Dec 27, 8:39 AM

In D48208#1099344, @manu wrote:

Not sure I understand.
The firmwares are installed in /boot/firmware and loads correctly here, why do you want to use the iwlwifi firmwares ?

Because in theory it is the same file I assume?

This will not be maintainable either as iwlwifi is about to vanish from the src.git (as most other firmware will likely follow over time) and version numbers may change in ports; iwlwifi actually tries the entire valid window from MAX to MIN. This is just looking for trouble.

In D48208#1099323, @bz wrote:

If you do not need the old firmware anymore please remove it entirely and update the documentation.

There is HOWEVER a theoretical problem there: if iwlwifi ever bumps the firmware version, say for a security update, there is not guarantee that iwm can parse them properly.

Sure, but bumping the firmware version also requires driver changes. So you can't just bump the firmware version by itself.

-adrian

aha, talking with manu, there's something off with my install here, those files SHOULD exist in /boot/firmware but don't.

I'll go delete this diff from my stack once I've verified updating/build/installworld fixes things.

adrian abandoned this revision.Fri, Dec 27, 2:17 PM

adrian removed a child revision: D48209: iwm: update rate tables from OpenBSD.

adrian removed a parent revision: D48172: net80211: add macros for testing if a channel is defined / channel is "any channel".