Page MenuHomeFreeBSD
Differential D48199

Add ctfdiff
Needs ReviewPublic
Actions

Authored by aokblast on Wed, Dec 25, 1:29 PM.
Tags
None
Referenced Files
F107074524: D48199.diff
Thu, Jan 9, 5:29 PM
F107031325: D48199.diff
Thu, Jan 9, 5:59 AM
Unknown Object (File)
Sun, Jan 5, 11:34 PM
Unknown Object (File)
Sat, Jan 4, 5:09 AM
Unknown Object (File)
Thu, Jan 2, 11:51 AM
Unknown Object (File)
Tue, Dec 31, 5:19 PM
Unknown Object (File)
Tue, Dec 31, 7:20 AM
Unknown Object (File)
Mon, Dec 30, 7:29 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
lwhsu
emaste
imp
markj
jhb
Summary

Wiki Page on introducing how to use this tool: https://wiki.freebsd.org/ShengYiHong/ABIStability

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61328
Build 58212: arc lint + arc unit

Event Timeline

aokblast created this revision.Wed, Dec 25, 1:29 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 25, 1:29 PM
aokblast requested review of this revision.Wed, Dec 25, 1:29 PM
Harbormaster completed remote builds in B61328: Diff 148388.Wed, Dec 25, 1:29 PM
aokblast updated this revision to Diff 148389.Wed, Dec 25, 1:34 PM

Remove unused CTF in Makefile

Harbormaster completed remote builds in B61329: Diff 148389.Wed, Dec 25, 1:34 PM
aokblast added a reviewer: lwhsu.Wed, Dec 25, 1:34 PM
aokblast updated this revision to Diff 148390.Wed, Dec 25, 1:36 PM

Move into usr.bin

Harbormaster completed remote builds in B61330: Diff 148390.Wed, Dec 25, 1:36 PM
aokblast added a comment.EditedWed, Dec 25, 1:39 PM

The elf parse, ctf parser is all from ctfdump and refactor it into C++. However, because it is cddl licensed, I am wondering if there is any legal concern?

lwhsu added reviewers: emaste, imp, markj, jhb.Wed, Dec 25, 1:40 PM
aokblast edited the summary of this revision. (Show Details)Wed, Dec 25, 1:41 PM
lwhsu added inline comments.Wed, Dec 25, 1:43 PM
usr.bin/ctfdiff/ctfdiff.1
8

Should the copyright header be yours?

aokblast updated this revision to Diff 148391.Wed, Dec 25, 1:55 PM

Modify copyright header

Harbormaster completed remote builds in B61331: Diff 148391.Wed, Dec 25, 1:55 PM
aokblast updated this revision to Diff 148392.Wed, Dec 25, 2:23 PM

Use correct license header

Harbormaster completed remote builds in B61332: Diff 148392.Wed, Dec 25, 2:23 PM
lwhsu added a comment.Wed, Dec 25, 4:12 PM
In D48199#1099009, @aokblast wrote:

The elf parse, ctf parser is all from ctfdump and refactor it into C++. However, because it is cddl licensed, I am wondering if there is any legal concern?

So not only included the CDDL headers but also some code derived from CDDL files?

cc @imp

Revision Contents
Changeset List

PathSize
cddl/
usr.bin/
3 lines
targets/
pseudo/
userland/
cddl/
1 line
usr.bin/
ctfdiff/
33 lines
12 lines
88 lines
735 lines
69 lines
94 lines
394 lines
476 lines
28 lines
148 lines
34 lines
7 lines

Diff 148388

View Options

cddl/usr.bin/Makefile

Loading...
View Options

targets/pseudo/userland/cddl/Makefile.depend

Loading...
View Options

usr.bin/ctfdiff/Makefile

Loading...
View Options

usr.bin/ctfdiff/Makefile.inc

Loading...
View Options

usr.bin/ctfdiff/ctfdata.hpp

Loading...
View Options

usr.bin/ctfdiff/ctfdata.cc

Loading...
View Options

usr.bin/ctfdiff/ctfdiff.1

Loading...
View Options

usr.bin/ctfdiff/ctfdiff.cc

Loading...
View Options

usr.bin/ctfdiff/ctftype.hpp

Loading...
View Options

usr.bin/ctfdiff/ctftype.cc

Loading...
View Options

usr.bin/ctfdiff/metadata.hpp

Loading...
View Options

usr.bin/ctfdiff/metadata.cc

Loading...
View Options

usr.bin/ctfdiff/utility.hpp

Loading...
View Options

usr.bin/ctfdiff/utility.cc

Loading...