[PATCH] security/sudo: Add sssd flavor
ClosedPublic
Actions

Authored by kiwi on Dec 19 2024, 12:25 PM.

Details

Reviewers

0mp
garga

Commits

R11:68af7b3d319e: security/sudo: Add sssd flavor

Summary

security/sudo: Add sssd flavor

Sudo with sssd support is a good candidate
for a flavor because it is a fairly common requirement
in some deployments.

Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Approved by:    garga (maintainer)

Test Plan

Tested with poudriere on both flavor (default and sssd) on 13.4-RELEASE.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kiwi requested review of this revision.Dec 19 2024, 12:25 PM

kiwi created this revision.

LGTM

Regarding the commit message, I'd suggest something along the lines of:

security/sudo: Add sssd flavor

Sudo with sssd support is a  a good candidate
for a flavor because it is a fairly common requirement
in some deployments.

Let's use security/sssd2 for that instead of security/sssd
as the later is deprecated.

This revision is now accepted and ready to land.Mon, Jan 6, 1:41 PM

LGTM as well and I also agree with @0mp suggestion for commit log

Rebased patch, and fixed the summary since sssd2 is the only sssd option since Jan 1 2025.

This revision now requires review to proceed.Fri, Jan 10, 1:28 PM

kiwi edited the test plan for this revision. (Show Details)Fri, Jan 10, 1:29 PM

0mp accepted this revision.Fri, Jan 10, 2:56 PM

This revision is now accepted and ready to land.Fri, Jan 10, 2:56 PM

Closed by commit R11:68af7b3d319e: security/sudo: Add sssd flavor (authored by kiwi). · Explain WhyFri, Jan 10, 3:05 PM

This revision was automatically updated to reflect the committed changes.

kiwi added a commit: R11:68af7b3d319e: security/sudo: Add sssd flavor.

I fail to see why the SSSD2 option is not removed completely. Flavors are dependable options. A flavor can be thought of as an option that other ports may depend on, because it produces a separate package.

With ports current state it is possible to get sudo-default with SSSD2 turned on and sudo-sssd with SSSD2 turned off.

In D48147#1104408, @arrowd wrote:

I fail to see why the SSSD2 option is not removed completely. Flavors are dependable options. A flavor can be thought of as an option that other ports may depend on, because it produces a separate package.

With ports current state it is possible to get sudo-default with SSSD2 turned on and sudo-sssd with SSSD2 turned off.

sssd has been removed from port tree on Jan 1srt, see https://reviews.freebsd.org/D48389 unfortunatly.
The option systems still works. So you can have (localy) a sudo(-default) with sssd2 turned on if you need. (or OPTION_SET+=SSSD2 on your /etc/make.conf )