release: Use unprivileged mode for bootonly and mini-memstick
ClosedPublic
Actions

Authored by emaste on Dec 17 2024, 3:19 PM.

Details

Reviewers

guest-patmaddox
brooks

Group Reviewers

releng

Commits

rGcbba69fb5793: release: Use unprivileged mode for bootonly and mini-memstick

Summary

This in effect always builds these targets in NO_ROOT mode, removing
one more instance where release artifact builds require a privileged
user (root). These artifacts are now always built the same way.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Dec 17 2024, 3:19 PM

Herald added a subscriber: jrtc27. · View Herald TranscriptDec 17 2024, 3:19 PM

emaste requested review of this revision.Dec 17 2024, 3:19 PM

brooks accepted this revision.Dec 17 2024, 8:44 PM

This revision is now accepted and ready to land.Dec 17 2024, 8:44 PM

emaste added inline comments.Dec 17 2024, 8:51 PM

release/Makefile
321	As an aside I opened PR283387 NO_ROOT/METALOG support required for release/scripts/pkg-stage.sh for this. I believe this is the only issue standing in the way of using NO_ROOT for all of the release artifact targets.

LGTM

I discovered PR284795 as a result of this work -- examining the resulting iso with bsdtar shows e.g.

drwx------  18 0      0        4096 Feb 13 13:53 .
drwxr-xr-x  2 0      0        6144 Feb 13 13:53 bin
-r-xr-xr-x  6 0      0           0 Feb 13 13:53 bin/cat link to bin
-r-xr-xr-x  6 0      0           0 Feb 13 13:53 bin/chflags link to bin
-r-xr-xr-x  6 0      0           0 Feb 13 13:53 bin/chio link to bin
...

This is solved by either one of D49134 and D49141; I will not commit this change until one of them is in.

emaste added a subscriber: releng.Sat, Mar 1, 9:44 PM

emaste retitled this revision from release: Use NO_ROOT mode for bootonly and mini-memstick to release: Use unprivileged mode for bootonly and mini-memstick.Tue, Mar 4, 6:06 PM

emaste edited the summary of this revision. (Show Details)

Closed by commit rGcbba69fb5793: release: Use unprivileged mode for bootonly and mini-memstick (authored by emaste). · Explain WhyFri, Mar 7, 11:47 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGcbba69fb5793: release: Use unprivileged mode for bootonly and mini-memstick.

Herald added a subscriber: imp. · View Herald TranscriptFri, Mar 7, 11:47 AM