As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute* and package*") we pass -NO_ROOT for the release image artifact build targets.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I wouldn't be surprised if we find some cases where people have to adapt to this change, but I think it's the right one. Eventually we might even want to forbid root entirely for this target, but that may be a bridge too far.
Makefile.inc1 | ||
---|---|---|
1006 | ..? |
I wouldn't be surprised if we find some cases where people have to adapt to this change, but I think it's the right one.
Yes - it just enforces what we always set in release/Makefile now, but indeed there may be downstream users of our build infrastructure that will need to adapt. I should send a note to appropriate mailing list(s) about unprivileged and reproducible builds and NO_ROOT.
Eventually we might even want to forbid root entirely for this target, but that may be a bridge too far.
We could at least emit a warning that running this target at root is not recommended.