Page MenuHomeFreeBSD
Differential D48053

xen/netfront: use iflladdr_event to send ARPs
ClosedPublic
Actions

Authored by glebius on Dec 12 2024, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 10:48 AM
Unknown Object (File)
Thu, Dec 26, 11:55 AM
Unknown Object (File)
Thu, Dec 26, 8:10 AM
Unknown Object (File)
Thu, Dec 26, 4:11 AM
Unknown Object (File)
Tue, Dec 24, 2:04 PM
Unknown Object (File)
Fri, Dec 20, 8:23 PM
Unknown Object (File)
Fri, Dec 20, 12:30 PM
Unknown Object (File)
Fri, Dec 20, 2:01 AM
View All 11 Files
Subscribers
ehem_freebsd_m5p.com
imp

Details

Reviewers
bz
jhibbits
royger
ehem_freebsd_m5p.com
Group Reviewers
network
Commits
rG2ef97d8b7564: xen/netfront: use iflladdr_event to send ARPs
Summary

Avoids usage of arp_ifinit() and if_foreach_addr_type(). The former
isn't encouraged to be used in drivers and the latter is about to
change to not expose struct ifaddr.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61111
Build 57995: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 12 2024, 2:12 PM
Herald added subscribers: ehem_freebsd_m5p.com, imp. · View Herald TranscriptDec 12 2024, 2:12 PM
glebius requested review of this revision.Dec 12 2024, 2:12 PM
Harbormaster completed remote builds in B61111: Diff 147856.Dec 12 2024, 2:12 PM
glebius added a parent revision: D48052: IfAPI: add if_getaddr().Dec 12 2024, 2:12 PM
glebius added a child revision: D48054: IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacks.
glebius added a reviewer: royger.Dec 12 2024, 2:13 PM
ehem_freebsd_m5p.com accepted this revision.Dec 12 2024, 9:33 PM

I'm guessing Phabricator/arcanist got updated and so new things are being created with dependencies matching git commit order (which is a good rough guess, but not always perfect). Appears D48052 is not a parent of D48053, but instead a parent of . Mainly D48052 and D48053 need to be committed before D48054; but D48052 and D48053 can be committed in either order.

Once I got my build tree back together, I was able to successfully build with D48053. The build booted successfully and demonstrated functioning network access on Xen/ARM64. Seems fine to me.

This revision is now accepted and ready to land.Dec 12 2024, 9:33 PM
royger accepted this revision.Fri, Dec 13, 8:50 AM

Tested with an amd64 VM live migration and still can see the ARP on resume.

sys/dev/xen/netfront/netfront.c
1072

Would you mind dropping the extra '*' while moving the comment? It's not inline with our comments coding style.

Closed by commit rG2ef97d8b7564: xen/netfront: use iflladdr_event to send ARPs (authored by glebius). · Explain WhyMon, Dec 16, 2:50 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG2ef97d8b7564: xen/netfront: use iflladdr_event to send ARPs.

Revision Contents
Changeset List

PathSize
sys/
dev/
xen/
netfront/
28 lines

Diff 147856

View Options

sys/dev/xen/netfront/netfront.c

Loading...