ext2fs: 'struct ufid': Re-order fields and unpack
ClosedPublic
Actions

Authored by olce on Dec 6 2024, 10:19 PM.

Details

Reviewers

markj
emaste
kib
rmacklem

Commits

rGacdc59f0924a: ext2fs: 'struct ufid': Re-order fields and unpack
rG6b1a5d3535d9: ext2fs: 'struct ufid': Re-order fields and unpack
rG8ae6247aa966: ext2fs: 'struct ufid': Re-order fields and unpack

Summary

Re-ordering the fields suppresses the trailing padding which was causing
the structure to overflow 'struct fid'.

While here, re-indent in a more visually pleasing way.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Dec 6 2024, 10:19 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2024, 10:19 PM

olce requested review of this revision.Dec 6 2024, 10:19 PM

Harbormaster completed remote builds in B60996: Diff 147628.Dec 6 2024, 10:19 PM

olce mentioned this in D47879: cd9660: Make sure that struct ifid fits in generic filehandle structure.Dec 6 2024, 10:34 PM

Looks fine to me.

This revision is now accepted and ready to land.Dec 6 2024, 11:33 PM

Yes ext2fs conveniently has a 32-bit field that can be relocated so we can avoid __packed.

markj accepted this revision.Dec 9 2024, 2:03 PM

Closed by commit rG8ae6247aa966: ext2fs: 'struct ufid': Re-order fields and unpack (authored by olce). · Explain WhyDec 13 2024, 2:06 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG8ae6247aa966: ext2fs: 'struct ufid': Re-order fields and unpack.

olce added a commit: rG6b1a5d3535d9: ext2fs: 'struct ufid': Re-order fields and unpack.Fri, Jan 17, 1:53 PM

olce added a commit: rGacdc59f0924a: ext2fs: 'struct ufid': Re-order fields and unpack.Fri, Jan 17, 2:00 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

inode.h

10 lines

Diff 147921

View Options

ext2fs: 'struct ufid': Re-order fields and unpackClosedPublicActions