Paths

Table of Contentst

Differential D47869

comsat: move uid/gid setting earlier
ClosedPublic
Actions

Authored by emaste on Dec 2 2024, 5:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 9, 9:24 PM

	Unknown Object (File)
	Sat, Mar 8, 1:29 PM

	Unknown Object (File)
	Fri, Mar 7, 9:06 PM

	Unknown Object (File)
	Thu, Mar 6, 4:22 AM

	Unknown Object (File)
	Mon, Mar 3, 2:17 PM

	Unknown Object (File)
	Sun, Mar 2, 4:45 PM

	Unknown Object (File)
	Sun, Mar 2, 2:58 PM

	Unknown Object (File)
	Sat, Mar 1, 7:33 AM

View All 29 Files

Subscribers

Details

Reviewers

Commits

rG30bcbf8a2fef: comsat: move uid/gid setting earlier
rG91629228e3df: comsat: move uid/gid setting earlier

Summary

It's good to reduce privilege as early as possible.

Suggested by:   jlduran
Obtained from:  NetBSD
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 2 2024, 5:48 PM

emaste created this revision.

jlduran added inline comments.Dec 2 2024, 6:38 PM

libexec/comsat/comsat.c
60	To ensure `hostname` is null-terminated (can be submitted separately, if considered appropriate).
62
148
185
186
200
216

Sorry about that, actually test building the change :)

jlduran accepted this revision.Dec 2 2024, 7:42 PM

This revision is now accepted and ready to land.Dec 2 2024, 7:42 PM

Closed by commit rG91629228e3df: comsat: move uid/gid setting earlier (authored by emaste). · Explain WhyDec 2 2024, 7:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG91629228e3df: comsat: move uid/gid setting earlier.

Herald added a subscriber: imp. · View Herald TranscriptDec 2 2024, 7:57 PM

emaste added a commit: rG30bcbf8a2fef: comsat: move uid/gid setting earlier.Dec 4 2024, 6:39 PM

Revision Contents
Changeset List

Path

Size

libexec/

comsat/

23 lines

Diff 147373

libexec/comsat/comsat.c

Loading...