iflib: Set the NUMA domain in receive packet headers
ClosedPublic
Actions

Authored by markj on Nov 29 2024, 4:09 PM.

Details

Reviewers

kbowling
zlei
shurd
erj

Group Reviewers

iflib

Commits

rG113875f91607: iflib: Set the NUMA domain in receive packet headers
rG3d642b0f71c5: iflib: Set the NUMA domain in receive packet headers

Summary

Reading PR 273559 made me realize that commit 767723ddebe9 is
incomplete. iflib should set the NUMA domain of received packets before
passing them to protocol layers.

PR: 273559
Fixes: 767723ddebe9 ("iflib: Use if_alloc_dev() to allocate the ifnet")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60876
Build 57760: arc lint + arc unit

Event Timeline

markj created this revision.Nov 29 2024, 4:09 PM

Herald added a reviewer: shurd. · View Herald TranscriptNov 29 2024, 4:09 PM

Herald added 1 blocking reviewer(s): iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

markj requested review of this revision.Nov 29 2024, 4:09 PM

Harbormaster completed remote builds in B60876: Diff 147165.Nov 29 2024, 4:09 PM

kbowling accepted this revision.Nov 29 2024, 10:29 PM

This revision is now accepted and ready to land.Nov 29 2024, 10:29 PM

erj accepted this revision.Nov 29 2024, 10:44 PM

Looks good to me.

Closed by commit rG3d642b0f71c5: iflib: Set the NUMA domain in receive packet headers (authored by markj). · Explain WhyDec 4 2024, 6:35 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3d642b0f71c5: iflib: Set the NUMA domain in receive packet headers.

markj added a commit: rG113875f91607: iflib: Set the NUMA domain in receive packet headers.Wed, Dec 18, 1:47 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

3 lines

Diff 147165

View Options

iflib: Set the NUMA domain in receive packet headersClosedPublicActions