Page MenuHomeFreeBSD

sockstat: Ensure that there is always a space between columns
ClosedPublic

Authored by markj on Nov 29 2024, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 2:31 PM
Unknown Object (File)
Tue, Mar 4, 4:41 PM
Unknown Object (File)
Feb 4 2025, 10:39 AM
Unknown Object (File)
Jan 27 2025, 1:45 PM
Unknown Object (File)
Jan 27 2025, 1:12 PM
Unknown Object (File)
Jan 19 2025, 2:23 AM
Unknown Object (File)
Jan 13 2025, 4:22 PM
Unknown Object (File)
Jan 10 2025, 5:46 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 29 2024, 3:52 PM
asomers added a subscriber: asomers.

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

This revision is now accepted and ready to land.Nov 29 2024, 6:23 PM

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

I can only agree.