Page MenuHomeFreeBSD

sockstat: Ensure that there is always a space between columns
ClosedPublic

Authored by markj on Nov 29 2024, 3:52 PM.
Tags
None
Referenced Files
F115477489: D47840.diff
Thu, Apr 24, 6:53 AM
Unknown Object (File)
Mon, Apr 21, 3:58 AM
Unknown Object (File)
Mon, Apr 21, 12:27 AM
Unknown Object (File)
Sun, Apr 20, 10:54 PM
Unknown Object (File)
Sun, Apr 20, 9:55 PM
Unknown Object (File)
Thu, Apr 17, 12:29 AM
Unknown Object (File)
Wed, Mar 26, 11:05 AM
Unknown Object (File)
Mar 12 2025, 2:31 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 29 2024, 3:52 PM
asomers added a subscriber: asomers.

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

This revision is now accepted and ready to land.Nov 29 2024, 6:23 PM

This looks like a good incremental change, although I can't test it right now. But this program is also begging for some TLC. It could benefit from libxo output, and it's also a good candidate for a C++ conversion. The entire -w option seems like an avoidable hack, if output were printed more intelligently. Most ambitiously of all, this program is fairly begging for some kind of "xo_print_table" function, that would automatically size the columns. But your change is still a good one by itself.

I can only agree.