mtree: TESTSBASE directory always starts with a /

[jlduran]

Summary

Remove the extra forward slash ("/"), otherwise the mtree specification
file will have the double slash and will not be parsed by makefs when
attempting to build NanoBSD with NO_ROOT privileges.

Fixes: 07670b30fa43 ("Create /usr/tests *.debug file directory hierarchy")

[emaste]

This is fine with me, but you could instead strip a leading / from TESTBASE if present, e.g. /usr/lib/debug/${TESTBASE:S,^/,,}. This will be robust against a possible TESTBASE without a leading slash.

[jlduran]

In D47722#1090635, @emaste wrote:

This is fine with me, but you could instead strip a leading / from TESTBASE if present, e.g. /usr/lib/debug/${TESTBASE:S,^/,,}. This will be robust against a possible TESTBASE without a leading slash.

I like this suggestion, I'll submit it on a separate review, as TESTSBASE is used in some other places as well.

[jlduran]

Also, I have yet to investigate if the mtree parsing under makefs is too strict (https://cgit.freebsd.org/src/tree/usr.sbin/makefs/mtree.c#n1004). But I'll check that once I have finished polishing building NanoBSD without root privileges (https://reviews.freebsd.org/D47653#1086475, https://www.youtube.com/watch?v=5qCaOMQ3ZnQ&t=2917s).

[jlduran]

In D47722#1090657, @jlduran wrote:

Also, I have yet to investigate if the mtree parsing under makefs is too strict (https://cgit.freebsd.org/src/tree/usr.sbin/makefs/mtree.c#n1004). But I'll check that once I have finished polishing building NanoBSD without root privileges (https://reviews.freebsd.org/D47653#1086475, https://www.youtube.com/watch?v=5qCaOMQ3ZnQ&t=2917s).

The underlying issue was that, when sorting the metalog, the double slash came up first. For example:

./base/aaa type=dir
./base//aaa/bbb type=dir

If sorted, would turn out:

./base//aaa/bbb type=dir
./base/aaa type=dir

Effectively, missing the ./base/aaa directory in the specification.