Page MenuHomeFreeBSD
Differential D47648

ktrace.1: Add ARGS and ENVS as default trace points
ClosedPublic
Actions

Authored by jlduran on Nov 17 2024, 5:55 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Jan 5, 9:34 PM
Unknown Object (File)
Sun, Jan 5, 8:35 AM
Unknown Object (File)
Sun, Jan 5, 7:28 AM
Unknown Object (File)
Sun, Jan 5, 1:09 AM
Unknown Object (File)
Dec 6 2024, 11:42 PM
Unknown Object (File)
Nov 23 2024, 6:12 PM
Unknown Object (File)
Nov 23 2024, 5:46 AM
Unknown Object (File)
Nov 22 2024, 7:25 AM
View All 14 Files
Subscribers
imp

Details

Reviewers
emaste
markj
Commits
rG2a657b4ee900: ktrace.1: Add ARGS and ENVS as default trace points
Summary

After commit 65a4daeaf324 ("ktrace: log execve(2) arguments and
environment"), "a" and "e" are part of the default set of trace points.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60645
Build 57529: arc lint + arc unit

Event Timeline

jlduran created this revision.Nov 17 2024, 5:55 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 17 2024, 5:55 PM
jlduran requested review of this revision.Nov 17 2024, 5:55 PM
Harbormaster completed remote builds in B60645: Diff 146617.Nov 17 2024, 5:55 PM
jlduran mentioned this in D47642: ktrace: Do not set args and envs as default.Nov 17 2024, 5:55 PM
markj accepted this revision.Nov 17 2024, 6:00 PM

Thank you.

Regarding these being the defaults, I don't have a strong opinion, but it seems natural for them to be enabled by default as they're effectively an extension of c. That is, they're pretty-printers for execve(2) arguments.

This revision is now accepted and ready to land.Nov 17 2024, 6:00 PM
Closed by commit rG2a657b4ee900: ktrace.1: Add ARGS and ENVS as default trace points (authored by jlduran). · Explain WhyNov 17 2024, 6:14 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG2a657b4ee900: ktrace.1: Add ARGS and ENVS as default trace points.
jlduran added a comment.Nov 17 2024, 6:17 PM
In D47648#1086370, @markj wrote:

Thank you.

You're welcome, and thank you for fixing the tests.

Regarding these being the defaults, I don't have a strong opinion, but it seems natural for them to be enabled by default as they're effectively an extension of c. That is, they're pretty-printers for execve(2) arguments.

Neither do I. Primarily motivated by fixing the tests without actually modifying them. Generally that will be my approach.

ziaee added a project: manpages.Nov 17 2024, 6:37 PM

Revision Contents
Changeset List

PathSize
usr.bin/
ktrace/
4 lines

Diff 146617

View Options

usr.bin/ktrace/ktrace.1

Loading...