Differential D47568

mv: More style nits.
AcceptedPublic
Actions

Authored by des on Thu, Nov 14, 11:31 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Group Reviewers

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60554
Build 57438: arc lint + arc unit

Event Timeline

des created this revision.Thu, Nov 14, 11:31 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 14, 11:31 AM

des requested review of this revision.Thu, Nov 14, 11:31 AM

Harbormaster completed remote builds in B60554: Diff 146438.Thu, Nov 14, 11:31 AM

des added a child revision: D47569: mv: Convert tests to ATF..Thu, Nov 14, 11:31 AM

Fine with me aside from the one comment.

bin/mv/mv.c
221	style(9) explicitly permits this, and I don't see a good reason to move the declarations.

This revision is now accepted and ready to land.Thu, Nov 14, 2:39 PM

des added inline comments.Thu, Nov 14, 4:34 PM

bin/mv/mv.c
221	It stuck out as being the only local definition in a file that otherwise declares all its variables at the top of each function. It shouldn't make any difference to the generated code.

markj added inline comments.Thu, Nov 14, 8:35 PM

bin/mv/mv.c
221	I understand that it won't change any code, I just think it doesn't make sense to move variables to a larger scope for no reason. Anyway, I don't object to either version.

Revision Contents
Changeset List

Path

Size

bin/

mv/

37 lines

Diff 146438

bin/mv/mv.c

Loading...