netlink: use size_t through the allocation KPI
Needs ReviewPublic
Actions

Authored by glebius on Wed, Nov 13, 9:55 PM.

Details

Reviewers

Group Reviewers

Summary

This fixes some signedness bugs and potential underflows. The length of
nl_buf is still limited by UINT_MAX and this is asserted now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60530
Build 57414: arc lint + arc unit

Event Timeline

glebius created this revision.Wed, Nov 13, 9:55 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 13, 9:55 PM

glebius requested review of this revision.Wed, Nov 13, 9:55 PM

glebius added a parent revision: D47550: netlink: check buffer length fits into u_int.

glebius added a child revision: D47552: netlink: use correct uint16_t type for attribute type & length.

Harbormaster completed remote builds in B60530: Diff 146382.Wed, Nov 13, 9:56 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

ktest_netlink_message_writer.h

4 lines

netlink_domain.c

2 lines

netlink_glue.c

5 lines

netlink_message_writer.h

14 lines

netlink_message_writer.c

14 lines

netlink_var.h

2 lines

Diff 146382

View Options

sys/netlink/ktest_netlink_message_writer.h

View Options

sys/netlink/netlink_domain.c

View Options

sys/netlink/netlink_glue.c

View Options

sys/netlink/netlink_message_writer.h

View Options

sys/netlink/netlink_message_writer.c

View Options

netlink: use size_t through the allocation KPINeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 146382

sys/netlink/ktest_netlink_message_writer.h

sys/netlink/netlink_domain.c

sys/netlink/netlink_glue.c

sys/netlink/netlink_message_writer.h

sys/netlink/netlink_message_writer.c

sys/netlink/netlink_var.h

netlink: use size_t through the allocation KPI
Needs ReviewPublic
Actions

Revision Contents
Changeset List