Make the CTL tests more resilient
ClosedPublic
Actions

Authored by asomers on Nov 5 2024, 12:28 AM.

Details

Reviewers

emaste
markj

Group Reviewers

cam

Commits

rGb032be711c74: Make the CTL tests more resilient

Summary

Fix the find_device function to work regardless of whether "camcontrol
devlist" lists the da device first and the pass device second or vice
versa. On FreeBSD 14 and 15 it apparently always lists da first. But
on 13 it can do it in either order.

MFC after: 2 weeks
MFC with: fe1755fa
Sponsored by: ConnectWise

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Nov 5 2024, 12:28 AM

Herald added a reviewer: cam. · View Herald TranscriptNov 5 2024, 12:28 AM

Herald added a subscriber: imp. · View Herald Transcript

asomers requested review of this revision.Nov 5 2024, 12:28 AM

Harbormaster completed remote builds in B60390: Diff 146017.Nov 5 2024, 12:28 AM

MFC with: can instead be Fixes: - we will have tooling to find commits that have a Fixes: identifying a commit that has been MFC'd

This revision is now accepted and ready to land.Nov 5 2024, 12:45 AM

markj accepted this revision.Nov 5 2024, 12:55 AM

Closed by commit rGb032be711c74: Make the CTL tests more resilient (authored by asomers). · Explain WhyNov 5 2024, 2:07 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGb032be711c74: Make the CTL tests more resilient.

Revision Contents
Changeset List

Path

Size

tests/

sys/

cam/

ctl/

ctl.subr

9 lines

Diff 146032

View Options

tests/sys/cam/ctl/ctl.subr

Make the CTL tests more resilientClosedPublicActions