Page MenuHomeFreeBSD

release: factor out common code from make-memstick.sh
AcceptedPublic

Authored by bz on Nov 3 2024, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 3:19 PM
Unknown Object (File)
Tue, Jan 21, 3:56 AM
Unknown Object (File)
Dec 27 2024, 6:39 PM
Unknown Object (File)
Dec 5 2024, 9:39 PM
Unknown Object (File)
Dec 2 2024, 6:50 PM
Unknown Object (File)
Nov 28 2024, 12:00 PM
Unknown Object (File)
Nov 8 2024, 10:30 PM
Unknown Object (File)
Nov 8 2024, 8:04 PM

Details

Reviewers
andrew
emaste
Group Reviewers
releng
Summary

Move make-memstick.sh to scripts to provide a common framework.
It seemed that all four implementations were copied from one or
another while mostly being the same.

The only differences really are the layout of the created disk image
(with or without a possible ESP) which is now provided as a target
architecture specific function while the common code is simply included.

Sponsored by: The FreeBSD Foundation

Test Plan

NOT FOR 14.2; so low prio.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60354
Build 57238: arc lint + arc unit

Event Timeline

bz requested review of this revision.Nov 3 2024, 12:20 AM

I think we can reduce some duplication in memstick_mkimg later, but this is a great start

This revision is now accepted and ready to land.Nov 20 2024, 1:27 PM

Thanks for the review; this was based on an earlier attempt to look at release (April this year?) for firmware and trying to figure out how things are put together.
I'll let it sit until at least RC1 is out in case other changes need to be done to avoid conflicts.

Yeah I'd hold off on this until after 14.2 is out the door

release/amd64/make-memstick.sh
6–7

These lines are a bit odd

release/scripts/make-memstick.sh
32

I mean, yeah, it is in practice, but can we just pass in a string representing which script we're running (i.e. what MACHINE is)?