Page MenuHomeFreeBSD

loader: Fix boot menu on BIOS
ClosedPublic

Authored by imp on Sat, Nov 2, 4:33 PM.
Tags
None
Referenced Files
F102043656: D47403.id145893.diff
Wed, Nov 6, 9:56 PM
F102043653: D47403.id145892.diff
Wed, Nov 6, 9:56 PM
F102043640: D47403.id.diff
Wed, Nov 6, 9:56 PM
F102043570: D47403.id145908.diff
Wed, Nov 6, 9:55 PM
F102043567: D47403.id145890.diff
Wed, Nov 6, 9:55 PM
F102043533: D47403.id145907.diff
Wed, Nov 6, 9:54 PM
Unknown Object (File)
Tue, Nov 5, 7:55 AM
Unknown Object (File)
Mon, Nov 4, 12:19 AM

Details

Summary

Only the gfx-enabled boot loader supports unicode. Otherwise, we have to
use the old cons25 / ibmpc upper code page drawing characters. Check to
see if we have the gfx.term_drawbox function. If we do, we support the
unicode drawing characters. If we don't, then we have an older loader
that doesn't support it *OR* we have the reduced function, text-only
boot loader. Either way, we need to use the old graphics characters.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60345
Build 57229: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sat, Nov 2, 4:33 PM

Tested successfully on a laptop: first, running stable/14-n269448-4e8444d5750a, then running main-n273387-bb8b3b174118.

Update to move these knowledge into core.hasUnicode() in case
other issues like this crop up, or in case we export this knowledge
more directly.

better comment
also remove comment from where we create old bindings:
with this new setup they aren't relevant.

emaste added inline comments.
stand/lua/core.lua
548 ↗(On Diff #145893)
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Nov 2, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Thank you for coming up with the solution. I can confirm that it fixes the issue for sc(4). Please don't hesitate to push it, preferably shortly.
Edit:
Wow.... already committed. Impressive timings!