vt: add comments for KDMKTONE ioctl implementation
ClosedPublic
Actions

Authored by emaste on Nov 1 2024, 4:29 PM.

Tags

None

Referenced Files

	F115654857: D47395.id145885.diff
	Sat, Apr 26, 3:28 PM

	Unknown Object (File)
	Wed, Apr 16, 6:53 PM

	Unknown Object (File)
	Sat, Apr 12, 1:35 PM

	Unknown Object (File)
	Mar 12 2025, 2:01 AM

	Unknown Object (File)
	Mar 5 2025, 3:11 AM

	Unknown Object (File)
	Mar 3 2025, 5:29 AM

	Unknown Object (File)
	Mar 2 2025, 1:09 AM

	Unknown Object (File)
	Feb 10 2025, 3:22 PM

View All 25 Files

Subscribers

None

Details

Reviewers

imp

Commits

rG752c25c01c17: vt: add comments for KDMKTONE ioctl implementation
rGadba3c74209e: vt: add comments for KDMKTONE ioctl implementation

Summary

It appears we implemented the same KDMKTONE ioctl as Linux, which specifies the frequency as an 8254 PIT divisor for a 1.19MHz clock. Add a comment to vtterm_beep to avoid someone wanting to "fix" this in the future.

Also add an XXX comment that the period unit is supposed to be "timer ticks." Nothing in the base system uses this ioctl.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Nov 1 2024, 4:29 PM

emaste created this revision.

imp accepted this revision.Nov 2 2024, 4:53 AM

This revision is now accepted and ready to land.Nov 2 2024, 4:53 AM

Closed by commit rGadba3c74209e: vt: add comments for KDMKTONE ioctl implementation (authored by emaste). · Explain WhyNov 2 2024, 2:39 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGadba3c74209e: vt: add comments for KDMKTONE ioctl implementation.

emaste added a commit: rG752c25c01c17: vt: add comments for KDMKTONE ioctl implementation.Nov 4 2024, 1:55 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

vt/

vt_core.c

8 lines

Diff 145869

View Options

vt: add comments for KDMKTONE ioctl implementationClosedPublicActions