Differential D47371

miibus: Use a bus_child_deleted method to free ivars for children
ClosedPublic
Actions

Authored by jhb on Thu, Oct 31, 8:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 7:20 AM

	Unknown Object (File)
	Fri, Nov 1, 5:46 PM

Subscribers

None

Details

Reviewers

Commits

rGdc569c894207: miibus: Use a bus_child_deleted method to free ivars for children

Summary

If a device was detached (e.g. via devctl) and then re-attached, the
ivars would be freed by the previous bus_child_detached method during
detach, but device_get_ivars during the subsequent attach would return
a stale pointer resulting in a use after free.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Thu, Oct 31, 8:36 PM

jhb created this revision.

Harbormaster completed remote builds in B60308: Diff 145802.Thu, Oct 31, 8:36 PM

jhb added a parent revision: D47370: iicbus: Use a bus_child_deleted method to free ivars for children.Thu, Oct 31, 8:36 PM

jhb added a child revision: D47372: smbus: Use a bus_child_deleted method to free ivars for children.

imp accepted this revision.Thu, Oct 31, 9:01 PM

This revision is now accepted and ready to land.Thu, Oct 31, 9:01 PM

Closed by commit rGdc569c894207: miibus: Use a bus_child_deleted method to free ivars for children (authored by jhb). · Explain WhyFri, Nov 1, 2:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdc569c894207: miibus: Use a bus_child_deleted method to free ivars for children.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mii/

6 lines

Diff 145845

sys/dev/mii/mii.c

Loading...