Page MenuHomeFreeBSD

sound: Move sysctl and /dev/dspX creation to pcm_setstatus()
ClosedPublic

Authored by christos on Oct 28 2024, 10:30 PM.
Tags
None
Referenced Files
F107150710: D47322.diff
Fri, Jan 10, 9:43 PM
Unknown Object (File)
Sun, Dec 29, 1:14 AM
Unknown Object (File)
Sat, Dec 21, 4:39 PM
Unknown Object (File)
Nov 21 2024, 2:13 PM
Unknown Object (File)
Nov 15 2024, 3:32 AM
Unknown Object (File)
Nov 6 2024, 8:43 AM
Unknown Object (File)
Nov 5 2024, 11:25 PM
Unknown Object (File)
Nov 4 2024, 1:38 AM
Subscribers

Details

Summary

Create the sysctl and /dev/dsp* nodes in pcm_setstatus(), which is
responsible for finalizing the device initialization, instead of doing
this in the middle of the initialization.

For the sysctl creation specifically, move them into pcm_sysinit(),
since this is where we create the rest of the sysctl nodes anyway.

A side effect of this change is, that we avoid the possibility of racing
in between pcm_register() and pcm_setstatus() by accessing /dev/dspX or
the sysctls within that window.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60231
Build 57115: arc lint + arc unit