Page MenuHomeFreeBSD
Differential D47309

malloc(9): assert wait flags.
ClosedPublic
Actions

Authored by des on Mon, Oct 28, 2:56 PM.
Tags
None
Referenced Files
F103077221: D47309.diff
Wed, Nov 20, 3:35 PM
Unknown Object (File)
Mon, Nov 18, 1:39 PM
Unknown Object (File)
Sun, Nov 10, 5:16 AM
Unknown Object (File)
Wed, Nov 6, 12:09 PM
Unknown Object (File)
Sat, Nov 2, 2:56 AM
Unknown Object (File)
Fri, Nov 1, 11:15 PM
Unknown Object (File)
Thu, Oct 31, 12:41 AM
Subscribers
olce

Details

Reviewers
imp
phk
olce
kevans
Group Reviewers
Klara
Commits
rGd0f9b0bd19bf: malloc(9): assert wait flags.
Summary

The check introduced in d3c11994e1e3 was bogus, combining a non-atomic
“once” flag with an equally non-thread-safe ppsratecheck. Rather than
fix it, just assert what it attempts to enforce: that the malloc flags
must include exactly one of M_WAITOK and M_NOWAIT.

Fixes: d3c11994e1e3de7445305abd0d41dce2b8d3e6dc
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mon, Oct 28, 2:56 PM
Herald added a subscriber: olce. · View Herald TranscriptMon, Oct 28, 2:56 PM
des requested review of this revision.Mon, Oct 28, 2:56 PM
Harbormaster completed remote builds in B60218: Diff 145532.Mon, Oct 28, 2:56 PM
des updated this revision to Diff 145533.Mon, Oct 28, 2:57 PM

trim stray newlines

Harbormaster completed remote builds in B60219: Diff 145533.Mon, Oct 28, 2:57 PM
olce requested changes to this revision.Mon, Oct 28, 3:04 PM
olce added inline comments.
sys/kern/kern_malloc.c
530

Parentheses missing.

This revision now requires changes to proceed.Mon, Oct 28, 3:04 PM
des updated this revision to Diff 145611.Tue, Oct 29, 5:40 PM

operator precedence

Harbormaster completed remote builds in B60250: Diff 145611.Tue, Oct 29, 5:40 PM
des marked an inline comment as done.Tue, Oct 29, 5:41 PM
olce accepted this revision.Tue, Oct 29, 5:43 PM
This revision is now accepted and ready to land.Tue, Oct 29, 5:43 PM
kevans accepted this revision.Tue, Oct 29, 6:17 PM
Closed by commit rGd0f9b0bd19bf: malloc(9): assert wait flags. (authored by des). · Explain WhyThu, Oct 31, 12:43 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGd0f9b0bd19bf: malloc(9): assert wait flags..

Revision Contents
Changeset List

PathSize
sys/
kern/
22 lines

Diff 145704

View Options

sys/kern/kern_malloc.c

Loading...