Page MenuHomeFreeBSD
Differential D47286

lib/libc/string: add memset_explicit() for compliance with C23
ClosedPublic
Actions

Authored by fuz on Oct 25 2024, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 8:15 AM
Unknown Object (File)
Tue, Jan 14, 8:14 AM
Unknown Object (File)
Sun, Jan 12, 11:27 AM
Unknown Object (File)
Fri, Dec 27, 7:57 AM
Unknown Object (File)
Thu, Dec 26, 6:52 AM
Unknown Object (File)
Dec 11 2024, 8:00 PM
Unknown Object (File)
Nov 22 2024, 8:53 AM
Unknown Object (File)
Nov 22 2024, 5:40 AM
View All 22 Files
Subscribers
imp

Details

Reviewers
kevans
emaste
Commits
rG8983acc8dee5: lib/libc/string: apply SSP hardening and tests to memset_explicit
rG007871c35628: lib/libc/string: add memset_explicit() for compliance with C23
Summary

Patterned after explicit_bzero sans the hook.
SSP hardening is provided, too.
The function is documented in memset(3).

Test Plan

passes newly added unit tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60557
Build 57441: arc lint + arc unit

Event Timeline

fuz created this revision.Oct 25 2024, 5:48 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 25 2024, 5:48 PM
fuz requested review of this revision.Oct 25 2024, 5:48 PM
Harbormaster completed remote builds in B60194: Diff 145466.Oct 25 2024, 5:48 PM
fuz added a parent revision: D47284: contrib/mandoc: add -isoC-2024 and -svid1 to mdoc(7).Oct 25 2024, 5:49 PM
fuz updated this revision to Diff 146441.Nov 14 2024, 12:39 PM
  • lib/libc/string/memset_explicit.c: add weak hook to confuse LTO inlining

As requested by @emaste.

Harbormaster completed remote builds in B60557: Diff 146441.Nov 14 2024, 12:39 PM
kevans added a comment.Nov 14 2024, 4:30 PM

fortify bits look good, thanks

include/string.h
74

I believe

kevans accepted this revision.Nov 14 2024, 4:30 PM
This revision is now accepted and ready to land.Nov 14 2024, 4:30 PM
Closed by commit rG007871c35628: lib/libc/string: add memset_explicit() for compliance with C23 (authored by fuz). · Explain WhyNov 14 2024, 10:11 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG007871c35628: lib/libc/string: add memset_explicit() for compliance with C23.
fuz added a commit: rG8983acc8dee5: lib/libc/string: apply SSP hardening and tests to memset_explicit.

Revision Contents
Changeset List

PathSize
include/
ssp/
2 lines
3 lines
lib/
libc/
string/
4 lines
4 lines
18 lines
27 lines
tests/
secure/
9 lines

Diff 146441

View Options

include/ssp/string.h

Loading...
View Options

include/string.h

Loading...
View Options

lib/libc/string/Makefile.inc

Loading...
View Options

lib/libc/string/Symbol.map

Loading...
View Options

lib/libc/string/memset.3

Loading...
View Options

lib/libc/string/memset_explicit.c

Loading...
View Options

lib/libc/tests/secure/fortify_string_test.c

Loading...
View Options

lib/libc/tests/secure/generate-fortify-tests.lua

Loading...