Page MenuHomeFreeBSD

sound: Remove redundant refcount checks in vchan_setnew()
ClosedPublic

Authored by christos on Wed, Oct 23, 9:11 PM.
Tags
None
Referenced Files
F102017265: D47268.diff
Wed, Nov 6, 2:35 PM
Unknown Object (File)
Sun, Nov 3, 12:54 PM
Unknown Object (File)
Sat, Nov 2, 2:05 PM
Unknown Object (File)
Wed, Oct 30, 2:10 PM
Unknown Object (File)
Mon, Oct 28, 6:09 AM
Unknown Object (File)
Fri, Oct 25, 11:41 AM
Subscribers

Details

Summary

When adding a new vchan, we are looking for a parent channel which
either already has vchans (i.e CHN_F_HAS_VCHAN), or does not, but is
also not being used (i.e !CHN_F_BUSY). Since CHN_F_BUSY essentially
tells us if the channel is currently being used or not, there is no need
to check if the channel's refcount is 0 as well.

When removing a vchan, we first check if we have only 1 vchan allocated
that is also being used (so we cannot remove it at the moment), and then
we check if the vchan is not busy and remove it. Again, checking
CHN_F_BUSY is enough.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60176
Build 57060: arc lint + arc unit