Could this be turned into an enum, to facilitate compiler checks in switch() statements? Or is there a policy on using enums in src? I see them far less often than I would expect.

In D47198#1076392, @dev_submerge.ch wrote:

Could this be turned into an enum, to facilitate compiler checks in switch() statements? Or is there a policy on using enums in src? I see them far less often than I would expect.

My plan was to convert more examples like this to enums in a follow up patch, but I've got no objection at all to making it an enum here.

Change to an enum.

Harbormaster completed remote builds in B60108: Diff 145230.Sun, Oct 20, 7:26 PM

markj added inline comments.Mon, Oct 21, 2:21 PM

sys/dev/sound/pcm/channel.h
339	I would consider giving this one a non-zero value, so that invalid values that arise from zero-initialization are more obvious.

Start from 1.

Harbormaster completed remote builds in B60128: Diff 145306.Mon, Oct 21, 6:49 PM

Seems ok to me.

An anonymous enum type isn't terribly useful, you'd need to start defining variables using the new enum type in order to get checking in switch statements and so on. But, it doesn't hurt either.

This revision is now accepted and ready to land.Mon, Oct 21, 8:55 PM

dev_submerge.ch accepted this revision.Tue, Oct 22, 11:26 AM

Closed by commit rGa4111e9dc722: sound: Change PCMDIR_* numbering (authored by christos). · Explain WhyThu, Oct 24, 11:38 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGa4111e9dc722: sound: Change PCMDIR_* numbering.

christos added a commit: rG26524f063fca: sound: Change PCMDIR_* numbering.Sun, Oct 27, 4:33 PM