bus_generic_detach: Remove redundant check
ClosedPublic
Actions

Authored by jhb on Wed, Oct 16, 3:27 PM.

Tags

None

Referenced Files

	F102016879: D47156.diff
	Wed, Nov 6, 2:30 PM

	F101958943: D47156.diff
	Tue, Nov 5, 7:49 PM

	Unknown Object (File)
	Tue, Oct 29, 10:53 PM

	Unknown Object (File)
	Fri, Oct 25, 12:25 AM

	Unknown Object (File)
	Sun, Oct 20, 9:36 PM

	Unknown Object (File)
	Sun, Oct 20, 9:36 PM

	Unknown Object (File)
	Sun, Oct 20, 9:36 PM

	Unknown Object (File)
	Sun, Oct 20, 9:07 PM

View All 13 Files

Subscribers

olce

Details

Reviewers

imp

Commits

rG3342afcbaf42: bus_generic_detach: Remove redundant check

Summary

device_detach() checks the device state and only calls a driver's
DEVICE_DETACH method if the device is attached but not busy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60043
Build 56927: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Oct 16, 3:27 PM

Herald added a subscriber: olce. · View Herald TranscriptWed, Oct 16, 3:27 PM

jhb requested review of this revision.Wed, Oct 16, 3:27 PM

Harbormaster completed remote builds in B60043: Diff 144996.Wed, Oct 16, 3:27 PM

jhb added a parent revision: D47155: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.Wed, Oct 16, 3:27 PM

jhb added a child revision: D47157: devinfo: Output device description in verbose mode.

imp accepted this revision.Wed, Oct 16, 3:31 PM

This revision is now accepted and ready to land.Wed, Oct 16, 3:31 PM

Closed by commit rG3342afcbaf42: bus_generic_detach: Remove redundant check (authored by jhb). · Explain WhyWed, Oct 16, 6:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3342afcbaf42: bus_generic_detach: Remove redundant check.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_bus.c

3 lines

Diff 144996

View Options

bus_generic_detach: Remove redundant checkClosedPublicActions