Page MenuHomeFreeBSD
Differential D47148

nscd step6
Needs ReviewPublic
Actions

Authored by david_crossfamilyweb.com on Wed, Oct 16, 3:10 AM.

Details

Reviewers
markj
Summary

minor code quality fixups for getpwent.
implement libc side of grouplist and pivot lookups for caching

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

david_crossfamilyweb.com created this revision.Wed, Oct 16, 3:10 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 16, 3:10 AM
david_crossfamilyweb.com requested review of this revision.Wed, Oct 16, 3:10 AM
markj added inline comments.Thu, Oct 17, 3:02 PM
lib/libc/gen/getgrent.c
209
370

original_ngroups is an "untrusted" value, i.e., it comes from nscd. This code should at least verify that

  1. it's non-negative,
  2. that original_ngroups * sizeof(gid_t) won't overflow,

before doing math with it.

david_crossfamilyweb.com updated this revision to Diff 145071.Fri, Oct 18, 5:44 AM

Implemented all PR changes

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
120 lines
6 lines
include/
3 lines

Diff 145071

View Options

lib/libc/gen/getgrent.c

Loading...
View Options

lib/libc/gen/getpwent.c

Loading...
View Options

lib/libc/include/nscachedcli.h

Loading...