plic: tweak macro argument names
ClosedPublic
Actions

Authored by mhorne on Oct 15 2024, 6:35 PM.

Tags

None

Referenced Files

	F116117365: D47133.diff
	Fri, May 2, 5:10 PM

	Unknown Object (File)
	Tue, Apr 29, 1:58 AM

	Unknown Object (File)
	Feb 9 2025, 4:55 PM

	Unknown Object (File)
	Feb 8 2025, 12:19 AM

	Unknown Object (File)
	Jan 15 2025, 2:08 PM

	Unknown Object (File)
	Jan 15 2025, 1:38 PM

	Unknown Object (File)
	Jan 15 2025, 9:59 AM

	Unknown Object (File)
	Jan 12 2025, 2:37 AM

View All 16 Files

Subscribers

imp

Details

Reviewers

br
jrtc27

Group Reviewers

riscv

Commits

rG5050fdb6b60e: plic: tweak macro argument names

Summary

Be clearer in the intention. 'h' implies a hart ID, but these take
logical CPU IDs instead. 'n' is acceptable, but '_irq' is clearer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Oct 15 2024, 6:35 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 15 2024, 6:35 PM

mhorne requested review of this revision.Oct 15 2024, 6:35 PM

Harbormaster completed remote builds in B60016: Diff 144943.Oct 15 2024, 6:35 PM

br accepted this revision.Oct 24 2024, 6:07 PM

This revision is now accepted and ready to land.Oct 24 2024, 6:07 PM

Closed by commit rG5050fdb6b60e: plic: tweak macro argument names (authored by mhorne). · Explain WhyOct 30 2024, 6:21 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG5050fdb6b60e: plic: tweak macro argument names.

Revision Contents
Changeset List

Path

Size

sys/

riscv/

plic.c

14 lines

Diff 145682

View Options

plic: tweak macro argument namesClosedPublicActions