Page MenuHomeFreeBSD
Differential D47132

tests: Fix style of netpfil/common/divapp.c
ClosedPublic
Actions

Authored by igoro on Oct 15 2024, 5:24 PM.
Tags
None
Referenced Files
F108829398: D47132.id144984.diff
Tue, Jan 28, 10:04 AM
F108825793: D47132.id145000.diff
Tue, Jan 28, 8:58 AM
Unknown Object (File)
Mon, Jan 27, 4:50 PM
Unknown Object (File)
Mon, Jan 27, 4:46 PM
Unknown Object (File)
Fri, Jan 24, 7:26 PM
Unknown Object (File)
Fri, Jan 24, 4:57 PM
Unknown Object (File)
Thu, Jan 23, 4:39 PM
Unknown Object (File)
Wed, Jan 15, 12:57 AM
View All 27 Files
Subscribers
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
kp
markj
Commits
rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60015
Build 56900: arc lint + arc unit

Event Timeline

igoro created this revision.Oct 15 2024, 5:24 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro, imp. · View Herald TranscriptOct 15 2024, 5:24 PM
igoro requested review of this revision.Oct 15 2024, 5:24 PM
Harbormaster completed remote builds in B60015: Diff 144934.Oct 15 2024, 5:24 PM
markj added inline comments.Oct 15 2024, 8:27 PM
tests/sys/netpfil/common/divapp.c
108

If you use err() instead of errx(), information from errno will be appended automatically.

igoro updated this revision to Diff 144984.Oct 16 2024, 10:27 AM

Use the standard way for error reporting

Harbormaster completed remote builds in B60033: Diff 144984.Oct 16 2024, 10:27 AM
igoro marked an inline comment as done.Oct 16 2024, 10:28 AM
igoro added inline comments.
tests/sys/netpfil/common/divapp.c
108

Nice, thanks.

markj accepted this revision.Oct 16 2024, 1:02 PM

Approved.

This revision is now accepted and ready to land.Oct 16 2024, 1:02 PM
Closed by commit rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c (authored by igoro). · Explain WhyOct 16 2024, 4:26 PM
This revision was automatically updated to reflect the committed changes.
igoro marked an inline comment as done.
igoro added a commit: rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c.

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
common/
9 lines

Diff 144934

View Options

tests/sys/netpfil/common/divapp.c

Loading...