Differential D47103

dpaa2: allow tapping of tx packet in dpni
ClosedPublic
Actions

Authored by bz on Sun, Oct 13, 11:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 3:53 AM

	Unknown Object (File)
	Wed, Oct 23, 10:31 AM

	Unknown Object (File)
	Mon, Oct 14, 5:52 PM

Subscribers

matt_traverse.com.au

Details

Reviewers

Commits

rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni
rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni

Summary

Packet capturing on dpni is only half-working given the BPF_MTAP call
in the TX is missing. Add it to see packets in both directions.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sun, Oct 13, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Oct 13, 11:18 PM

bz requested review of this revision.Sun, Oct 13, 11:18 PM

Harbormaster completed remote builds in B59965: Diff 144795.Sun, Oct 13, 11:18 PM

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

This revision is now accepted and ready to land.Mon, Oct 14, 10:57 AM

In D47103#1073636, @dsl wrote:

LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?

ether_input_internal()

Closed by commit rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni (authored by bz). · Explain WhyMon, Oct 14, 5:44 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGe69e172d4058: dpaa2: allow tapping of tx packets in dpni.

bz added a commit: rG9e596eab21d4: dpaa2: allow tapping of tx packets in dpni.Thu, Oct 17, 9:18 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

dpaa2/

2 lines

Diff 144838

sys/dev/dpaa2/dpaa2_ni.c

Loading...