release: tweak Oracle Cloud settings
ClosedPublic
Actions

Authored by dch on Fri, Oct 11, 12:13 PM.

Details

Reviewers

cperciva
lwhsu
emaste
dch

Commits

rG786ebfa46d22: release: tweak Oracle Cloud settings
rGc61104166084: release: tweak Oracle Cloud settings

Summary

use raw image disk type and enable zfs, this yields smaller images for upload after using native qcow2 + zstd compression

Test Plan

removed bump image size due to python bloat in cloudinit packages because re-testing shows its no longer required

$ qemu-img convert -S 512b -p \
  -O qcow2 -c -o compression_type=zstd  \
  /usr/obj/usr/src/amd64.amd64/release/oracle.zfs.raw \
  /tmp/qc2

yields a 4.0GiB -> ~ 890MiB reduction :-)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59901
Build 56786: arc lint + arc unit

Event Timeline

dch created this revision.Fri, Oct 11, 12:13 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptFri, Oct 11, 12:13 PM

dch requested review of this revision.Fri, Oct 11, 12:13 PM

Harbormaster completed remote builds in B59901: Diff 144628.Fri, Oct 11, 12:13 PM

dch mentioned this in D46975: release: move OCI to ORACLE.Fri, Oct 11, 12:14 PM

Just to confirm, the Oracle upload system doesn't have any preference for disk image formats?

release/Makefile.vm
50	As with OCI->ORACLE rename, we want `=?` here.

It's interesting that using raw could result smaller image size than qcow2.

This revision is now accepted and ready to land.Mon, Oct 14, 8:05 PM

It's interesting that using raw could result smaller image size than qcow2.

I'm guessing this means we were generating an uncompressed qcow2, and converting raw to qcow2 includes compression as a side effect.

The image size bump doesn't seem to be reflected in this review (I'm guessing it got lost in the migration from the other review) but is fine with me.

release/Makefile.vm
50	`?=`

Make ORACLE_FSLIST? overridable.

This revision now requires review to proceed.Tue, Oct 15, 9:10 AM

Harbormaster completed remote builds in B59991: Diff 144878.Tue, Oct 15, 9:10 AM

i.e. raw > mkimg qcow2 > recompressed raw qcow2.

Oracle bills based on raw uploaded size, so saving 2/3 of the image size makes a big difference for everybody.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263029 for more details.

Ed - the VMSIZE change is in the next file.

This revision is now accepted and ready to land.Tue, Oct 15, 9:10 AM

LGTM with ?=

dch edited the summary of this revision. (Show Details)Tue, Oct 15, 1:04 PM

dch edited the test plan for this revision. (Show Details)

remove VMSIZE change we don't need it anymore

This revision now requires review to proceed.Tue, Oct 15, 1:12 PM

Harbormaster completed remote builds in B59994: Diff 144897.Tue, Oct 15, 1:12 PM

dch edited the summary of this revision. (Show Details)Wed, Oct 16, 5:40 AM

dch added inline comments.

release/tools/oracle.conf
29–30	this isn't required anymore - not sure what's changed, but I bumped this locally over a year ago, and I'm not seeing the bloat that broke images in the past.