Page MenuHomeFreeBSD
Differential D47018

shm_alloc(): cleanup
ClosedPublic
Actions

Authored by kib on Oct 8 2024, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 5:20 AM
Unknown Object (File)
Mon, Oct 28, 8:37 PM
Unknown Object (File)
Tue, Oct 15, 10:22 AM
Unknown Object (File)
Fri, Oct 11, 11:28 AM
Unknown Object (File)
Thu, Oct 10, 1:09 AM
Unknown Object (File)
Wed, Oct 9, 11:50 AM
Subscribers
glebius
imp
olce

Details

Reviewers
alc
markj
Commits
rGe578fd853a25: shm_alloc(): cleanup
Summary
Consistently use the shorter name 'obj' for the new object.
Set OBJ_POSIXSHM flag outside if, it is set on both pathes.

Suggested by:   alc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 8 2024, 5:50 PM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptOct 8 2024, 5:50 PM
kib requested review of this revision.Oct 8 2024, 5:50 PM

I think that unlocked assignment to swp/phys_priv is fine,the field is never changed after the initialization. I would even set the flag lockless, since the object is not yet visible, but I think the consistency is useful there, e.g. for sanitizers.

markj added inline comments.Tue, Oct 8, 8:42 PM
sys/kern/uipc_shm.c
947–948

The assignment to shmfd->shm_object here isn't needed.

kib updated this revision to Diff 144513.Wed, Oct 9, 7:12 AM
kib marked an inline comment as done.

Remove unneeded assignment.

alc accepted this revision.Wed, Oct 9, 8:10 AM
This revision is now accepted and ready to land.Wed, Oct 9, 8:10 AM
markj accepted this revision.Wed, Oct 9, 11:24 AM
Closed by commit rGe578fd853a25: shm_alloc(): cleanup (authored by kib). · Explain WhyWed, Oct 9, 11:42 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGe578fd853a25: shm_alloc(): cleanup.

Revision Contents
Changeset List

PathSize
sys/
kern/
18 lines

Diff 144527

View Options

sys/kern/uipc_shm.c

Loading...