dummymbuf: Fix code style
ClosedPublic
Actions

Authored by igoro on Oct 5 2024, 10:03 AM.

Tags

None

Referenced Files

	F102033286: D46958.diff
	Wed, Nov 6, 6:40 PM

	F102001605: D46958.id144299.diff
	Wed, Nov 6, 10:05 AM

	Unknown Object (File)
	Fri, Nov 1, 2:27 AM

	Unknown Object (File)
	Sat, Oct 26, 10:50 AM

	Unknown Object (File)
	Sat, Oct 26, 10:50 AM

	Unknown Object (File)
	Sat, Oct 26, 10:50 AM

	Unknown Object (File)
	Sat, Oct 26, 10:31 AM

	Unknown Object (File)
	Tue, Oct 8, 8:19 PM

Subscribers

Details

Reviewers

markj
kp

Commits

rG6bd8d85579a1: dummymbuf: Fix code style

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59784
Build 56670: arc lint + arc unit

igoro requested review of this revision.Oct 5 2024, 10:03 AM

Approved.

I was going to suggest not capitalising 'Fix', but apparently I am wrong about what our convention is there. See https://freebsdfoundation.org/wp-content/uploads/2020/11/Writing-Commit-Messages.pdf where Ed explicitly recommends "Capitalize the first letter of the subject", and I'm not going to argue with Ed.

I might include a 'No functional change' in the commit message, just to be doubly explicit about that, but the first line already heavily implies it.

This revision is now accepted and ready to land.Oct 5 2024, 1:39 PM

This revision was automatically updated to reflect the committed changes.