mlock_test: use mmap/munmap for unmapped pointer
AcceptedPublic
Actions

Authored by brooks on Oct 4 2024, 11:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 12:25 AM

	Unknown Object (File)
	Sun, Oct 13, 10:57 AM

	Unknown Object (File)
	Thu, Oct 10, 11:27 PM

	Unknown Object (File)
	Thu, Oct 10, 11:27 PM

	Unknown Object (File)
	Oct 5 2024, 9:21 AM

	Unknown Object (File)
	Oct 5 2024, 7:30 AM

	Unknown Object (File)
	Oct 5 2024, 6:52 AM

Subscribers

imp

Details

Reviewers

ngie

Summary

Instead of hoping that the page after sbrk(0) is unmapped, map a page
with mmap and then munmap it. This won't work with CheriABI, but it's
an easy fix for now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 59773
Build 56659: arc lint + arc unit

Event Timeline

brooks created this revision.Oct 4 2024, 11:31 PM

Herald added a reviewer: ngie. · View Herald TranscriptOct 4 2024, 11:31 PM

Herald added a subscriber: imp. · View Herald Transcript

brooks requested review of this revision.Oct 4 2024, 11:31 PM

Harbormaster completed remote builds in B59773: Diff 144285.Oct 4 2024, 11:31 PM

brooks added a child revision: D42862: libc: stop exposing break/sbrk/brk.Oct 4 2024, 11:32 PM

ngie accepted this revision.Oct 5 2024, 3:57 AM

This revision is now accepted and ready to land.Oct 5 2024, 3:57 AM

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

lib/

libc/

sys/

t_mlock.c

14 lines

Diff 144285

View Options

contrib/netbsd-tests/lib/libc/sys/t_mlock.c

mlock_test: use mmap/munmap for unmapped pointerAcceptedPublicActions