Paths

Table of Contentst

Differential D46850

tcp: small cleanup
ClosedPublic
Actions

Authored by tuexen on Sep 30 2024, 6:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 25, 12:12 AM

	Unknown Object (File)
	Tue, Oct 15, 4:40 AM

	Unknown Object (File)
	Sat, Oct 12, 4:17 AM

	Unknown Object (File)
	Oct 4 2024, 10:09 PM

	Unknown Object (File)
	Oct 4 2024, 10:09 PM

	Unknown Object (File)
	Oct 4 2024, 10:09 PM

	Unknown Object (File)
	Oct 2 2024, 7:41 AM

	Unknown Object (File)
	Oct 1 2024, 6:41 PM

View All 9 Files

Subscribers

Details

Reviewers

markj
rscheff
cc
peter.lei_ieee.org
lstewart
glebius

Group Reviewers

Commits

rG5818c74e34a8: tcp: small cleanup
rGb785f83e987d: tcp: small cleanup
rG2eacb0841c7d: tcp: small cleanup

Summary

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Sep 30 2024, 6:56 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 30 2024, 6:56 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Sep 30 2024, 6:56 PM

glebius accepted this revision.Sep 30 2024, 7:00 PM

glebius added inline comments.

sys/netinet/tcp_syncache.c
1588	No objection on this change, but I personally preferred the original style.

tuexen marked an inline comment as done.Sep 30 2024, 7:14 PM

tuexen added inline comments.

sys/netinet/tcp_syncache.c
1588	Me too. But then the line is too long. The alternative would be: if ((sc = uma_zalloc(V_tcp_syncache.zone, M_NOWAIT \| M_ZERO)) == NULL) { I think the way proposed is simpler to read.

tuexen marked an inline comment as done.Sep 30 2024, 7:38 PM

markj accepted this revision.Oct 1 2024, 7:42 AM

rscheff accepted this revision.Oct 1 2024, 7:51 AM

This revision is now accepted and ready to land.Oct 1 2024, 7:51 AM

Looks good to me. Thanks for removing the goto label skip_alloc that improves reading.

Closed by commit rG2eacb0841c7d: tcp: small cleanup (authored by tuexen). · Explain WhyOct 1 2024, 3:34 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG2eacb0841c7d: tcp: small cleanup.

tuexen added a commit: rGb785f83e987d: tcp: small cleanup.Thu, Oct 31, 1:59 PM

tuexen added a commit: rG5818c74e34a8: tcp: small cleanup.Thu, Oct 31, 4:59 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

59 lines

Diff 144056

sys/netinet/tcp_syncache.c

Loading...