Page MenuHomeFreeBSD
Differential D46850

tcp: small cleanup
ClosedPublic
Actions

Authored by tuexen on Sep 30 2024, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 6:08 PM
Unknown Object (File)
Wed, Jan 22, 4:48 AM
Unknown Object (File)
Fri, Jan 17, 2:09 PM
Unknown Object (File)
Dec 23 2024, 6:17 AM
Unknown Object (File)
Dec 9 2024, 1:25 AM
Unknown Object (File)
Nov 29 2024, 8:43 PM
Unknown Object (File)
Nov 22 2024, 5:30 PM
Unknown Object (File)
Nov 10 2024, 1:42 PM
View All 18 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
markj
rscheff
cc
peter.lei_ieee.org
lstewart
glebius
Group Reviewers
transport
Commits
rG5818c74e34a8: tcp: small cleanup
rGb785f83e987d: tcp: small cleanup
rG2eacb0841c7d: tcp: small cleanup
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Sep 30 2024, 6:56 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 30 2024, 6:56 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Sep 30 2024, 6:56 PM
glebius accepted this revision.Sep 30 2024, 7:00 PM
glebius added inline comments.
sys/netinet/tcp_syncache.c
1588

No objection on this change, but I personally preferred the original style.

tuexen marked an inline comment as done.Sep 30 2024, 7:14 PM
tuexen added inline comments.
sys/netinet/tcp_syncache.c
1588

Me too. But then the line is too long. The alternative would be:

if ((sc = uma_zalloc(V_tcp_syncache.zone,
    M_NOWAIT | M_ZERO)) == NULL) {

I think the way proposed is simpler to read.

tuexen marked an inline comment as done.Sep 30 2024, 7:38 PM
markj accepted this revision.Oct 1 2024, 7:42 AM
rscheff accepted this revision.Oct 1 2024, 7:51 AM
This revision is now accepted and ready to land.Oct 1 2024, 7:51 AM
cc accepted this revision.Oct 1 2024, 1:42 PM

Looks good to me. Thanks for removing the goto label skip_alloc that improves reading.

Closed by commit rG2eacb0841c7d: tcp: small cleanup (authored by tuexen). · Explain WhyOct 1 2024, 3:34 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG2eacb0841c7d: tcp: small cleanup.
tuexen added a commit: rGb785f83e987d: tcp: small cleanup.Oct 31 2024, 1:59 PM
tuexen added a commit: rG5818c74e34a8: tcp: small cleanup.Oct 31 2024, 4:59 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
59 lines

Diff 144056

View Options

sys/netinet/tcp_syncache.c

Loading...