LinuxKPI: add cleanup.h for guard DEFINE_GUARD/guard.
ClosedPublic
Actions

Authored by bz on Sep 29 2024, 1:01 AM.

Details

Reviewers

Group Reviewers

Commits

rG75ac24a7dfeb: LinuxKPI: add cleanup.h for guard DEFINE_GUARD/guard.
rGfa81baa307da: LinuxKPI: add cleanup.h for guard DEFINE_GUARD/guard.

Summary

iwlwifi v6.11 started to use guard(). _T in the implementation needs
to be exposed to the driver which uses it in DEFINE_GUARD().

Given this is the first instance of attribute(cleanup) in the tree:

gcc has support for it since at least 2003-06-04 (0bfa5f65bfb186f10d43304946fd7fcd69988732)
llvm gained support on 2009-01-31 (d277d790e0f6f23043397ba919619b5c3e157ff3, llvm-svn 63462).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sep 29 2024, 1:01 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptSep 29 2024, 1:01 AM

bz requested review of this revision.Sep 29 2024, 1:01 AM

Harbormaster completed remote builds in B59650: Diff 143893.Sep 29 2024, 1:01 AM

emaste added inline comments.Sep 30 2024, 2:52 PM

sys/compat/linuxkpi/common/include/linux/cleanup.h
14	Since this will be the first use of this we probably want a note about compiler support (either in comment or in the commit message), even if the note is not specific versions and just that it has been supported for quite some time in Clang and GCC (if that's the case).
18	might want to clarify this comment, the "scare quotes" around "excellent" might not be universally understood to indicate this is actually not excellent.

bz added inline comments.Sep 30 2024, 6:35 PM

sys/compat/linuxkpi/common/include/linux/cleanup.h
14	I don't know if it is the first use but I looked up at https://clang.llvm.org/docs/AttributeReference.html#cleanup that clang supports it. I was hoping they would list from which versions; is there an easy why but looking at the source or going back version by version in the docs to see when it appeared?

bz added inline comments.Sat, Oct 12, 10:12 PM

sys/compat/linuxkpi/common/include/linux/cleanup.h
14	Took a bit but I went and checked.. if I read the commits and code correctly: gcc has support for it since at least 2003-06-04 (0bfa5f65bfb186f10d43304946fd7fcd69988732) [not sure it it was there earlier already]. llvm gained support on 2009-01-31 (d277d790e0f6f23043397ba919619b5c3e157ff3, llvm-svn 63462) So should also be save to MFC to all supported branches. Should I mention them specifically like this or keep it general? I think 'd prefer the commit message then it's found in the history and not buried in code.
18	I'll update it.

Should I mention them specifically like this or keep it general? I think 'd prefer the commit message then it's found in the history and not buried in code.

Since you looked it up might as well keep the version info. I'm fine with putting it in the commit message.

bz edited the summary of this revision. (Show Details)Sun, Oct 13, 8:39 PM