Page MenuHomeFreeBSD
Differential D46841

LinuxKPI: add time_is_before_jiffies()
ClosedPublic
Actions

Authored by bz on Sep 29 2024, 12:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 11:08 AM
Unknown Object (File)
Dec 7 2024, 8:15 PM
Unknown Object (File)
Nov 28 2024, 9:33 PM
Unknown Object (File)
Nov 17 2024, 4:46 AM
Unknown Object (File)
Nov 6 2024, 2:22 PM
Unknown Object (File)
Nov 4 2024, 4:22 AM
Unknown Object (File)
Nov 4 2024, 4:22 AM
Unknown Object (File)
Nov 4 2024, 4:03 AM
View All 16 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG080484840344: LinuxKPI: add time_is_before_jiffies()
rG8f9567628cb2: LinuxKPI: add time_is_before_jiffies()
Summary

Add time_is_before_jiffies() as needed by iwlwifi from v6.11.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59659
Build 56546: arc lint + arc unit

Event Timeline

bz created this revision.Sep 29 2024, 12:58 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptSep 29 2024, 12:58 AM
bz requested review of this revision.Sep 29 2024, 12:58 AM
Harbormaster completed remote builds in B59648: Diff 143891.Sep 29 2024, 12:58 AM
emaste accepted this revision.Sep 30 2024, 2:55 PM

OK. Would time_before(a, jiffies) be more clear though?

This revision is now accepted and ready to land.Sep 30 2024, 2:55 PM
bz added a comment.Sep 30 2024, 6:33 PM
In D46841#1068245, @emaste wrote:

OK. Would time_before(a, jiffies) be more clear though?

I can do that; given time_before just expands to time_after(b, a) I had jumped that step. But you may be right, we have the tools; let's make this more human mind understandable. I'll switch it.

bz updated this revision to Diff 144058.Sep 30 2024, 7:42 PM

Use time_before instead of time_after as suggested by @emaste.

This revision now requires review to proceed.Sep 30 2024, 7:42 PM
Harbormaster completed remote builds in B59659: Diff 144058.Sep 30 2024, 7:42 PM
bz added a comment.Oct 10 2024, 11:23 PM

@emaste the updated version better?

emaste accepted this revision.Oct 11 2024, 2:33 PM
This revision is now accepted and ready to land.Oct 11 2024, 2:33 PM
Closed by commit rG8f9567628cb2: LinuxKPI: add time_is_before_jiffies() (authored by bz). · Explain WhyOct 11 2024, 8:50 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG8f9567628cb2: LinuxKPI: add time_is_before_jiffies().
bz added a commit: rG080484840344: LinuxKPI: add time_is_before_jiffies().Oct 17 2024, 9:18 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line

Diff 144058

View Options

sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...