Page MenuHomeFreeBSD

git-arc: Fix find_author() for external users
ClosedPublic

Authored by jlduran on Sep 25 2024, 5:44 PM.
Tags
None
Referenced Files
F102669165: D46789.diff
Fri, Nov 15, 3:07 PM
Unknown Object (File)
Thu, Nov 7, 9:20 PM
Unknown Object (File)
Tue, Nov 5, 6:30 AM
Unknown Object (File)
Mon, Oct 21, 10:57 PM
Unknown Object (File)
Oct 11 2024, 3:02 AM
Unknown Object (File)
Oct 9 2024, 12:04 PM
Unknown Object (File)
Sep 30 2024, 6:22 PM
Unknown Object (File)
Sep 30 2024, 3:19 PM
Subscribers
None

Details

Summary

When an external user submits a review in Phabricator, the find_author()
subroutine may receive the author_name and author_addr as "null" from
the JSON API with git-arc patch.

This "null" string gets tested for length by "[ -n", and returning that
is greater than zero, in other words, the shell does not understand that
"null" means nothing in this case.

Fix it by adding a guard, that sets an empty string when the content is
"null".

While here, standardize the indentation style for find_author()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59599
Build 56486: arc lint + arc unit