Differential D46783

mbuf: Don't force all M_EXTPG mbufs to be read-only
Needs ReviewPublic
Actions

Authored by jhb on Wed, Sep 25, 3:13 PM.

Tags

None

Referenced Files

	F96622916: D46783.diff
	Wed, Sep 25, 6:56 PM

	F96595888: D46783.id143714.diff
	Wed, Sep 25, 4:17 PM

	F96595716: D46783.id.diff
	Wed, Sep 25, 4:16 PM

	F96593554: D46783.diff
	Wed, Sep 25, 4:05 PM

Subscribers

Details

Reviewers

gallatin
kp

Summary

Some M_EXTPG mbufs are read-only (e.g. those backing sendfile
requests), but others are not. Add a flags argument to
mb_alloc_ext_pgs that can be used to set M_RDONLY when needed rather
than setting it unconditionally. Update mb_unmapped_to_ext to
preserve M_RDONLY from the unmapped mbuf.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59593
Build 56480: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Sep 25, 3:13 PM

Herald added subscribers: olce, glebius, ae, imp. · View Herald TranscriptWed, Sep 25, 3:13 PM

jhb requested review of this revision.Wed, Sep 25, 3:13 PM

Harbormaster completed remote builds in B59593: Diff 143714.Wed, Sep 25, 3:13 PM

jhb added a child revision: D46784: ktls: Mark mbufs containing outbound encrypted TLS records read-only.Wed, Sep 25, 3:13 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

cxgbei/

2 lines

tom/

2 lines

iscsi/

2 lines

nvmf/

2 lines

fs/

nfsclient/

2 lines

kern/

9 lines

kern_sendfile.c

2 lines

4 lines

sys/

2 lines

Diff 143714

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...

sys/dev/iscsi/icl_soft.c

Loading...

sys/dev/nvmf/nvmf_tcp.c

Loading...

sys/fs/nfsclient/nfs_clrpcops.c

Loading...

sys/kern/kern_mbuf.c

Loading...

sys/kern/kern_sendfile.c

Loading...

sys/kern/uipc_mbuf.c

Loading...

sys/sys/mbuf.h

Loading...