Page MenuHomeFreeBSD

git-arc: Make patch with reviewers more portable
AcceptedPublic

Authored by jlduran_gmail.com on Wed, Sep 25, 6:21 AM.
Tags
None
Referenced Files
F96729408: D46781.diff
Thu, Sep 26, 7:50 AM
Unknown Object (File)
Thu, Sep 26, 12:47 AM
Unknown Object (File)
Wed, Sep 25, 11:42 PM
Unknown Object (File)
Wed, Sep 25, 9:33 PM
Subscribers
None

Details

Reviewers
emaste
imp
markj
Summary

Avoid an ArcanistUsageException:

Provide method parameters on stdin as a JSON blob.

Due to an invalid JSON input on strict POSIX-compliant shells (macOS):

echo '{
        "constraints": {"phids": [-n,"PHID-USER-xxx",]}
      }'                          ^^^               ^

Change the non-portable "echo -n" to a printf.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59591
Build 56478: arc lint + arc unit

Event Timeline

jlduran_gmail.com created this revision.

I see a couple of other uses of echo -n, in gitarc__list().

Fix other occurrences of "echo -n" while here.

This revision is now accepted and ready to land.Wed, Sep 25, 7:20 AM