Page MenuHomeFreeBSD

tcp: further cleanup old options
AcceptedPublic

Authored by glebius on Tue, Sep 24, 9:46 PM.
Tags
None
Referenced Files
F97579867: D46779.diff
Mon, Sep 30, 4:29 AM
Unknown Object (File)
Thu, Sep 26, 4:50 AM
Unknown Object (File)
Wed, Sep 25, 5:06 PM
Unknown Object (File)
Wed, Sep 25, 5:06 PM
Unknown Object (File)
Wed, Sep 25, 4:56 PM
Subscribers

Details

Reviewers
tuexen
lstewart
Group Reviewers
transport
Summary

They all were experimental and some comments refer to internal Netflix
versions. There is not reason to leak that into the header. Style unused
options so that they have the available value aligned with really used
values.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59588
Build 56475: arc lint + arc unit

Event Timeline

Internally at Netflix I will make all private options relative to TCP_VENDOR. This will make my merging much easier. Ideally we even want this to become a enum, and that would protect again any collisions and other failures.

I was using the style used in netinet/in.h. But I do not care how we mark them as unused as long as it is consistent.

Internally at Netflix I will make all private options relative to TCP_VENDOR. This will make my merging much easier. Ideally we even want this to become a enum, and that would protect again any collisions and other failures.

Using an enum will break the logic, if someone uses the pattern

#ifdef TCP_OPTION_NAME
....
#endif

I do this, for example, in symbols_freebsd.c for packetdrill.
One solution would be to use an enum and also #define. Not elegant...

sys/netinet/tcp.h
279

This is used by BBR.

This revision is now accepted and ready to land.Sun, Sep 29, 2:25 PM