Page MenuHomeFreeBSD

pf tests: Remove nargs from single arguments
ClosedPublic

Authored by vegeta_tuxpowered.net on Sep 24 2024, 3:22 PM.
Tags
None
Referenced Files
F101994339: D46772.diff
Wed, Nov 6, 7:51 AM
Unknown Object (File)
Sat, Nov 2, 11:38 PM
Unknown Object (File)
Thu, Oct 31, 5:42 PM
Unknown Object (File)
Fri, Oct 25, 2:02 AM
Unknown Object (File)
Thu, Oct 24, 10:44 AM
Unknown Object (File)
Wed, Oct 16, 4:28 AM
Unknown Object (File)
Oct 2 2024, 7:08 PM
Unknown Object (File)
Sep 29 2024, 10:08 AM

Details

Summary

Using nargs=1 causes arguments to produce lists from which we must then
get the real value. The same applies to defaults, the must be provided
as arrays too.

Remove nargs=1 so that values and defaults can be accessed directly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This seems to include a move to sys/netpfil/common/pft_ping.py, but not the makefile changes that would require. I assume the move is not intended to be part of this patch?

Other than that this looks good, so when my test run completes I intend to commit this without the move.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 10:44 AM
This revision was automatically updated to reflect the committed changes.