Page MenuHomeFreeBSD
Differential D46771

loader: Use printc instead of print to fit in 24,80
ClosedPublic
Actions

Authored by imp on Tue, Sep 24, 3:02 PM.
Tags
None
Referenced Files
F97674263: D46771.diff
Mon, Sep 30, 5:20 PM
F97666190: D46771.id143683.diff
Mon, Sep 30, 4:23 PM
Unknown Object (File)
Sun, Sep 29, 2:53 AM
Unknown Object (File)
Thu, Sep 26, 11:29 AM
Unknown Object (File)
Wed, Sep 25, 9:08 PM
Unknown Object (File)
Wed, Sep 25, 11:02 AM
Unknown Object (File)
Tue, Sep 24, 5:19 PM
Unknown Object (File)
Tue, Sep 24, 5:19 PM
View All 12 Files
Subscribers
dab

Details

Reviewers
manu
kevans
Commits
rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80
Summary

print automatically adds a newline, while printc does not. Use printc in
preference to print for managing the autoboot message. This means we can
use line 24 safely on a 24x80 terminal, restoring some functionality that
was lost in 101afbc6ee2f0

Fixes: 101afbc6ee2f0
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59581
Build 56468: arc lint + arc unit

Event Timeline

imp created this revision.Tue, Sep 24, 3:02 PM
Herald added a reviewer: manu. · View Herald TranscriptTue, Sep 24, 3:02 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Tue, Sep 24, 3:02 PM
Harbormaster completed remote builds in B59580: Diff 143670.Tue, Sep 24, 3:02 PM
imp added a reviewer: kevans.Tue, Sep 24, 3:02 PM
kevans added inline comments.Tue, Sep 24, 3:08 PM
stand/lua/menu.lua
534

Move thec comment to the line above it, please, and this otherwise LGTM

imp updated this revision to Diff 143676.Tue, Sep 24, 4:20 PM

Update comments: (1) like kyle suggested and (2) reword the awkard comment about
a common (enough?) VT100 emulator bug that's easily avoided.

Harbormaster completed remote builds in B59581: Diff 143676.Tue, Sep 24, 4:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 24, 4:57 PM
Closed by commit rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80 (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80.

Revision Contents
Changeset List

PathSize
stand/
lua/
10 lines

Diff 143676

View Options

stand/lua/menu.lua

Loading...