loader: Use printc instead of print to fit in 24,80
ClosedPublic
Actions

Authored by imp on Sep 24 2024, 3:02 PM.

Details

Reviewers

manu
kevans

Commits

rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80

Summary

print automatically adds a newline, while printc does not. Use printc in
preference to print for managing the autoboot message. This means we can
use line 24 safely on a 24x80 terminal, restoring some functionality that
was lost in 101afbc6ee2f0

Fixes: 101afbc6ee2f0
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 24 2024, 3:02 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 24 2024, 3:02 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Sep 24 2024, 3:02 PM

Harbormaster completed remote builds in B59580: Diff 143670.Sep 24 2024, 3:02 PM

imp added a reviewer: kevans.Sep 24 2024, 3:02 PM

kevans added inline comments.Sep 24 2024, 3:08 PM

stand/lua/menu.lua
534	Move thec comment to the line above it, please, and this otherwise LGTM

Update comments: (1) like kyle suggested and (2) reword the awkard comment about
a common (enough?) VT100 emulator bug that's easily avoided.

Harbormaster completed remote builds in B59581: Diff 143676.Sep 24 2024, 4:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2024, 4:57 PM

Closed by commit rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80 (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG3fb656f8ef21: loader: Use printc instead of print to fit in 24,80.

Revision Contents
Changeset List

Path

Size

stand/

lua/

menu.lua

10 lines

Diff 143683

View Options

loader: Use printc instead of print to fit in 24,80ClosedPublicActions