sound: Move global variable initialization to sound_modevent()

[christos]

Summary

There is no reason to initialize global variables in feeder_register(),
as these variables are unrelated to what the function does. Instead,
initialize them during sound(4) load.

While here, fix the switch statement indentation in sound_modevent().

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

[zlei]

sys/dev/sound/pcm/feeder.c

66

This can also be moved to event handler of MOD_LOAD IMHO.

69

For the initialization of root feeder, it is special, I guess it deserves a dedicated function, aka feeder_register_root(). Then change the SYSINIT accordingly,

-SYSINIT(feeder_root, SI_SUB_DRIVERS, SI_ORDER_FIRST, feeder_register, &feeder_root_class);
+SYSINIT(feeder_root, SI_SUB_DRIVERS, SI_ORDER_FIRST, feeder_register_root, &feeder_root_class);

sys/dev/sound/pcm/sound.c

895

I'd support you move the initialization of those global variables into a dedicated function. It will be much clear IMHO.

[christos]

sys/dev/sound/pcm/feeder.c

66

This list is internal to feeder.c, so I will just move it to the new feeder_register_root() function.

69

D46821

[christos]

Move to separate function.

[zlei]

Looks good to me.

[emaste]

I'd probably use the full word global rather than glob, as glob has an existing meaning (even if not related to this context) and it's only two extra letters.

The whitespace fixup should be a separate commit, that can go first.

[zlei]

In D46749#1068241, @emaste wrote:

I'd probably use the full word global rather than glob, as glob has an existing meaning (even if not related to this context) and it's only two extra letters.

The whitespace fixup should be a separate commit, that can go first.

+1 for global.