ng_ubt_intel: Ignore unexpected HCI events
ClosedPublic
Actions

Authored by wulf on Sep 21 2024, 1:57 PM.

Details

Reviewers

Commits

rG0b23c50ae834: ng_ubt_intel: Ignore unexpected HCI events

Summary

If Intel firmware is already in operational mode at boot that takes
place at warm boot, BT adaptor can generate extra HCI events which
interferes with firmware mode detection logic. Ignore them.

Sponsored by: Future Crew LLC
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Sep 21 2024, 1:57 PM

Herald added subscribers: glebius, melifaro, donner, imp. · View Herald TranscriptSep 21 2024, 1:57 PM

wulf requested review of this revision.Sep 21 2024, 1:57 PM

Harbormaster completed remote builds in B59549: Diff 143568.Sep 21 2024, 1:57 PM

wulf mentioned this in D44861: Initial cut at Intel AX210 bluetooth support.Sep 21 2024, 2:11 PM

emaste added a subscriber: emaste.Sep 21 2024, 5:30 PM

shuriku_shurik.kiev.ua added a subscriber: shuriku_shurik.kiev.ua.Sep 23 2024, 5:25 AM

wulf mentioned this in D46734: ng_ubt_intel: Allow to attach to 9260 bluetooth adaptors.Sun, Oct 27, 11:37 AM

bz added inline comments.Mon, Oct 28, 2:34 AM

sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
577	space after if; can do before commit; no need for a new revision here.
864	see comment below
873	Here and above you man do a partial usbd_copy_out but then skipping the remainder. Is that save or will that confuse some other logic in case of a failing condition + "goto"? Should you do all the conditional checks first and then do the usbd_copy_out() all together?

wulf added inline comments.Mon, Oct 28, 11:56 AM

sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
873	I can't do any checks before data has been copied out of DMA-ble page cache. So I prefetch header to private on-stack memory to not thrash caller-supplied buffer on negative case, than do all the checks and than copy out all data to the buffer on success.