ctl: Correctly reject invalid service action for REPORT SUPPORTED OPCODES
Needs ReviewPublic
Actions

Authored by jhb on Mon, Sep 9, 6:14 PM.

Details

Reviewers

asomers
emaste
khorben_defora.org

Group Reviewers

cam

Summary

The service action field is only the low 5 bits of byte 1 in the CDB.
The upper 3 bits are reserved. If any of those bits are reserved
regardless of the reporting options flags, fail the request with an
INVALID FIELD IN COMMAND specifying byte 1 as the illegal byte.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59408
Build 56295: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Sep 9, 6:14 PM

Herald added a reviewer: cam. · View Herald TranscriptMon, Sep 9, 6:14 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Mon, Sep 9, 6:14 PM

Harbormaster completed remote builds in B59408: Diff 143151.Mon, Sep 9, 6:14 PM

jhb added a reviewer: khorben_defora.org.Mon, Sep 9, 6:14 PM

jhb added inline comments.

sys/cam/ctl/ctl.c
7485	Note that this is not a generic "there's an invalid field in the command", but is specifically saying that the RSO_OPTIONS field in the cdb->options byte is invalid.

asomers added inline comments.Mon, Sep 9, 6:21 PM

sys/cam/ctl/ctl.c
7439	Should "field" be 4 for REQUESTED SERVICE ACTION instead of 1 for SERVICE ACTION?

khorben_defora.org added a parent revision: Restricted Differential Revision.Tue, Sep 10, 10:56 PM

jhb added inline comments.Sat, Sep 14, 9:38 AM

sys/cam/ctl/ctl.c
7439	Sigh, yes, and actually, it needs to be ignored for RSO_OPTIONS_ALL and RSO_OPTIONS_OC so I need to revisit this a bit.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl.c

28 lines

Diff 143151

View Options

ctl: Correctly reject invalid service action for REPORT SUPPORTED OPCODESNeeds ReviewPublicActions